Re: [PATCH v6 4/6] power: supply: lenovo_yoga_c630_battery: add Lenovo C630 driver

[Sebastian Reichel]

Hi,

On Thu, Jun 13, 2024 at 10:57:41AM GMT, Ilpo Järvinen wrote:
> > +	adp_cfg.supplied_to = (char **)&yoga_c630_psy_bat_psy_desc_mA.name;
> 
> This is not problem with your patch but I'm wondering why supplied_to 
> needs to be non-const char *. Are those strings expected to be altered by 
> something, I couldn't find anything to that effect (the pointer itself 
> does not become const if supplied_to is changed to const char **)?

No, they are not supposed to be modified. It should be fine to make
the struct member const char **, patches are welcome :)

-- Sebastian

Attachment: signature.asc
Description: PGP signature