Re: [PATCH v5] drm/ci: add tests on vkms

[Vignesh Raman]

Hi Maxime,

On 13/06/24 22:58, Maxime Ripard wrote:
> Hi,
>
> On Thu, Jun 13, 2024 at 01:56:10PM GMT, Vignesh Raman wrote:
> > On 13/06/24 13:07, Maxime Ripard wrote:
> > > Hi,
> > >
> > > On Tue, Jun 11, 2024 at 02:40:37PM GMT, Vignesh Raman wrote:
> > > > diff --git a/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt b/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt
> > > > new file mode 100644
> > > > index 000000000000..56484a30aff5
> > > > --- /dev/null
> > > > +++ b/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt
> > > > @@ -0,0 +1,15 @@
> > > > +# Board Name: vkms
> > > > +# Bug Report: https://lore.kernel.org/dri-devel/61ed26af-062c-443c-9df2-d1ee319f3fb0@xxxxxxxxxxxxx/T/#u
> > > > +# Failure Rate: 50
> > > > +# IGT Version: 1.28-g0df7b9b97
> > > > +# Linux Version: 6.9.0-rc7
> > > > +kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic
> > > > +kms_flip@basic-flip-vs-wf_vblank
> > > > +kms_flip@flip-vs-expired-vblank-interruptible
> > > > +kms_flip@flip-vs-wf_vblank-interruptible
> > > > +kms_flip@plain-flip-fb-recreate-interruptible
> > > > +kms_flip@plain-flip-ts-check
> > > > +kms_flip@plain-flip-ts-check-interruptible
> > > > +kms_flip@flip-vs-absolute-wf_vblank
> > > > +kms_flip@flip-vs-absolute-wf_vblank-interruptible
> > > > +kms_flip@flip-vs-blocking-wf-vblank
> > >
> > > We should have the header for every line here
> >
> > All the flakes in these tests were observed with version
> > 6.9.0-rc7/1.28-g0df7b9b97. So can we group them together?
> >
> > If we update this file for different IGT/kernel version, we can add a
> > separate header for each test.
>
> If we don't however, we have no way to tell in a couple months whether
> those flakes were there before we were adding those metadata, or if the
> metadata applies to everything, or only a subset.

I will send a v6 with this change. Thanks.

Regards,
Vignesh