Re: [PATCH 3/3] scsi: pm8001: Update log level when reading config table

From: Jinpu Wang
Date: Fri Jun 14 2024 - 01:37:40 EST


On Fri, Jun 7, 2024 at 7:57 PM TJ Adams <tadamsjr@xxxxxxxxxx> wrote:
>
> From: Terrence Adams <tadamsjr@xxxxxxxxxx>
>
> Reading the main config table occurs as a part of initialization in
> pm80xx_chip_init(). Because of this it makes more sense to have it be a
> part of the INIT logging.
>
> Signed-off-by: Terrence Adams <tadamsjr@xxxxxxxxxx>
Acked-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index a52ae6841939..8fe886dc5e47 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -568,13 +568,13 @@ static void read_main_config_table(struct pm8001_hba_info *pm8001_ha)
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version =
> pm8001_mr32(address, MAIN_MPI_INACTIVE_FW_VERSION);
>
> - pm8001_dbg(pm8001_ha, DEV,
> + pm8001_dbg(pm8001_ha, INIT,
> "Main cfg table: sign:%x interface rev:%x fw_rev:%x\n",
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.signature,
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.interface_rev,
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.firmware_rev);
>
> - pm8001_dbg(pm8001_ha, DEV,
> + pm8001_dbg(pm8001_ha, INIT,
> "table offset: gst:%x iq:%x oq:%x int vec:%x phy attr:%x\n",
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.gst_offset,
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.inbound_queue_offset,
> @@ -582,7 +582,7 @@ static void read_main_config_table(struct pm8001_hba_info *pm8001_ha)
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.int_vec_table_offset,
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.phy_attr_table_offset);
>
> - pm8001_dbg(pm8001_ha, DEV,
> + pm8001_dbg(pm8001_ha, INIT,
> "Main cfg table; ila rev:%x Inactive fw rev:%x\n",
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.ila_version,
> pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version);
> --
> 2.45.2.505.gda0bf45e8d-goog
>