Re: [PATCH v5 5/8] dt-bindings: ufs: mediatek,ufs: Document MT8192 compatible with MT8183

From: Peter Wang (王信友)
Date: Fri Jun 14 2024 - 02:33:00 EST


On Wed, 2024-06-12 at 09:43 +0200, AngeloGioacchino Del Regno wrote:
> The MT8192 UFS controller is compatible with the MT8183 one:
> document this by allowing to assign both compatible strings
> "mediatek,mt8192-ufshci", "mediatek,mt8183-ufshci" to the UFSHCI
> node.
>
> Moreover, since no MT8192 devicetree ever declared any UFSHCI node,
> disallow specifying only the MT8192 compatible.
>
> In preparation for adding MT8195 to the mix, the MT8192 compatible
> was added as enum instead of const.
>
> Also, while at it, replace Stanley Chu with me in the maintainers
> field, as he is unreachable and his email isn't active anymore.
>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/ufs/mediatek,ufs.yaml | 11 +++++++
> ----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> index 32fd535a514a..f14887ea6fdc 100644
> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> @@ -7,16 +7,19 @@ $schema:
> https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!kyjoVMsolIn8UqpISxVGSoDhD_bRBX0JEC0OOPb5e1JsXd-TePG6OpTbK6Muyst5dg0grOuoNe3_H25C61ajBHgvNk_dYObW$
>
> title: Mediatek Universal Flash Storage (UFS) Controller
>
> maintainers:
> - - Stanley Chu <stanley.chu@xxxxxxxxxxxx>
> + - AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
>

Hi AngeloGioacchino,

Stanley Chu has left MediaTek.
I am the new MediaTek UFS maintainer.

Please see

https://patchwork.kernel.org/project/linux-mediatek/patch/20231117103810.527-1-chu.stanley@xxxxxxxxx/

The role of MediaTek UFS maintainer is not suitable to be handed over
to someone outside of MediaTek.

Thanks.
Peter


>
> allOf:
> - $ref: ufs-common.yaml
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt8183-ufshci
> - - mediatek,mt8192-ufshci
> + oneOf:
> + - const: mediatek,mt8183-ufshci
> + - items:
> + - enum:
> + - mediatek,mt8192-ufshci
> + - const: mediatek,mt8183-ufshci
>
> clocks:
> maxItems: 1