Re: [PATCH v9 1/1] gpio: add sloppy logic analyzer using polling

[Wolfram Sang]

Hi Arnd, everyone,

> I could imagine treating both gpio-virtuser and this code as
> a gpiolib extension rather than a consumer (which is usually
> part of some other subsystem's driver).

I have difficulties seeing this. For the analyzer, at least. It does not
extend gpiolib in a way another consumer could make use of it?

> It would also make sense to me to separate gpio providers
> from gpiolib in a way, moving one or both of them into a
> subdirectory of drivers/gpio/.

I'd also like 'drivers/gpio/providers' and leave the core stuff (incl.
the analyzer) in 'drivers/gpio'. But I am biased, I2C looks like this :)
And yes, this is some churn and git-history spoiling.

> gpiolib-virtuser.c and gpiolib-sloppy-logic-analyzer.c

'gpio-tool-sloppy-logic-analyzer.c' ? Based on what gets added to
Kconfig with this patch:

	+menu "GPIO hardware hacking tools"

Happy hacking,

   Wolfram

Attachment: signature.asc
Description: PGP signature