Re: [PATCH 3/3] block: BFQ: Refactor bfq_exit_icq() to silence sparse warning

From: Bart Van Assche
Date: Fri Jun 14 2024 - 12:39:09 EST


On 6/14/24 2:03 AM, John Garry wrote:
Currently building for C=1 generates the following warning:
block/bfq-iosched.c:5498:9: warning: context imbalance in 'bfq_exit_icq' - different lock contexts for basic block

Refactor bfq_exit_icq() into a core part which loops for the actuators,
and only lock calling this routine when necessary.

I like this patch because it makes the code easier to read.

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>