Re: [PATCH] drm/ci: mark kms_addfb_basic@addfb25-bad-modifier as passing on msm

[Helen Koike]

On 13/06/2024 14:55, Dmitry Baryshkov wrote:
> On Thu, 13 Jun 2024 at 20:49, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote:
> > On 6/13/2024 9:33 AM, Dmitry Baryshkov wrote:
> > > The commit b228501ff183 ("drm/msm: merge dpu format database to MDP
> > > formats") made get_format take modifiers into account. This makes
> > > kms_addfb_basic@addfb25-bad-modifier pass on MDP4 and MDP5 platforms.
> > >
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > ---
> > >    drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 1 -
> > >    drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt | 1 -
> > >    2 files changed, 2 deletions(-)
> >
> > Would be good to also give a link to the CI for the CI maintainers.
> >
> > But otherwise, LGTM
> >
> > Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>
> Yes, good idea: https://gitlab.freedesktop.org/drm/msm/-/merge_requests/119


Nice to see new tests passing!

Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>

I'm applying it to drm-misc-next

Thanks,
Helen

> > > diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> > > index 3dfbabdf905e..6e7fd1ccd1e3 100644
> > > --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> > > +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> > > @@ -4,7 +4,6 @@ device_reset@unbind-cold-reset-rebind,Fail
> > >    device_reset@unbind-reset-rebind,Fail
> > >    dumb_buffer@invalid-bpp,Fail
> > >    kms_3d,Fail
> > > -kms_addfb_basic@addfb25-bad-modifier,Fail
> > >    kms_cursor_legacy@forked-move,Fail
> > >    kms_cursor_legacy@single-bo,Fail
> > >    kms_cursor_legacy@torture-bo,Fail
> > > diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
> > > index 23a5f6f9097f..46ca69ce2ffe 100644
> > > --- a/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
> > > +++ b/drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt
> > > @@ -4,6 +4,5 @@ device_reset@unbind-cold-reset-rebind,Fail
> > >    device_reset@unbind-reset-rebind,Fail
> > >    dumb_buffer@invalid-bpp,Fail
> > >    kms_3d,Fail
> > > -kms_addfb_basic@addfb25-bad-modifier,Fail
> > >    kms_lease@lease-uevent,Fail
> > >    tools_test@tools_test,Fail
> > >
> > > ---
> > > base-commit: 6b4468b0c6ba37a16795da567b58dc80bc7fb439
> > > change-id: 20240613-msm-pass-addfb25-bad-modifier-c461fd9c02bb
> > >
> > > Best regards,