Re: [PATCH net-next 2/3] net: phy: dp83867: add cable test support

[Andrew Lunn]

On Fri, Jun 14, 2024 at 06:52:10PM +0200, João Rodrigues wrote:
> On Thu, 13 Jun 2024 19:19:45 +0200
> Andrew Lunn <andrew@xxxxxxx> wrote:
> 
> > > +/* TDR bits */
> > > +#define DP83867_TDR_GEN_CFG5_FLAGS	0x294A
> > > +#define DP83867_TDR_GEN_CFG6_FLAGS	0x0A9B  
> > 
> > Is it documented what these bits actually mean?
> > 
> >    Andrew
> 
> No, all three (CFG5, CFG6 and CFG7) are undocumented.

Then i would suggest you use the magic values directly.  The only
advantage i see with DP83867_TDR_GEN_CFG5_FLAGS is that is stops you
accidentally using it with CFG4, etc. But magic is magic, and you
should not really hide it.

       Andrew