Re: [PATCH] dt-bindings: thermal: convert hisilicon-thermal.txt to dt-schema

From: Javier Carrasco
Date: Fri Jun 14 2024 - 14:52:10 EST


On 14/06/2024 10:49, Krzysztof Kozlowski wrote:
> On 14/06/2024 00:42, Abdulrasaq Lawani wrote:
>> Convert the hisilicon SoCs tsensor txt bindings to dt-schema
>>
>> Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@xxxxxxxxx>
>> ---
>> Validated with dtschema and tested against `hi3660-hikey960.dts`
>>
>
>> + compatible = "hisilicon,tsensor";
>> + reg = <0x0 0xf7030700 0x0 0x1000>;
>
> Oh man... get this past your mentors first.
>
> 1. Messed indentation.
> 2. 0, unit address looks unnecessary.
>

Sorry Krzysztof, it seems that this conversion went "live" without a
preliminary review by the mentors. We will make sure that the first step
is not omitted for v2.

Best regards,
Javier Carrasco