Re: [PATCH v6 2/8] drm: Support per-plane async flip configuration

[André Almeida]

Em 14/06/2024 14:32, Dmitry Baryshkov escreveu:> On Fri, Jun 14, 2024 at 
12:35:29PM GMT, André Almeida wrote:
>> Drivers have different capabilities on what plane types they can or
>> cannot perform async flips. Create a plane::async_flip field so each
>> driver can choose which planes they allow doing async flips.
>>
>> Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx>
>> ---
>>   drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
>>   include/drm/drm_plane.h           | 5 +++++
>>   2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c 
b/drivers/gpu/drm/drm_atomic_uapi.c
>> index 2e1d9391febe..ed1af3455477 100644
>> --- a/drivers/gpu/drm/drm_atomic_uapi.c
>> +++ b/drivers/gpu/drm/drm_atomic_uapi.c
>> @@ -1079,9 +1079,9 @@ int drm_atomic_set_property(struct 
drm_atomic_state *state,
>>   			break;
>>   		}
>>
>> -		if (async_flip && plane_state->plane->type != 
DRM_PLANE_TYPE_PRIMARY) {
>> +		if (async_flip && !plane->async_flip) {
>
> So, after this patch async flips becomes disabled until the driver
> enables that manually. Whether that's desired or not is a separate
> topic, but this definitely should be explicitly mentioned in the commit
> message.
>

You are right, I think I should separate this in the last commit, so we 
don't have any regression commits. Thanks for the feedback