Re: [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow'

[Alexey Makhalov]

Thanks for the report and provided .config file.

The problem with DRM_VMWGFX=y when HYPERVISOR_GUEST is not set, i.e 
arch/x86/kernel/cpu/vmware.c is not built.
It is even a problem today. For VMWARE_HYPERCALL alternative to work, 
vmware guest code must set cpu capabilities properly.
The kernel based on the current config file will not work on a SEV-ES 
enabled machine.
DRM_VMWGFX must depend on HYPERVISOR_GUEST similarly to VMWARE_BALLOON, 
MOUSE_PS2_VMMOUSE and
PTP_1588_CLOCK_VMW.

Borislav, I'm going to send a fix shortly. It has to be applied before 
this patchset.

Thanks,
--Alexey

On 6/15/24 7:33 AM, Borislav Petkov wrote:
> On Sat, Jun 15, 2024 at 09:22:00PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vmware
> > head:   ef08e7dc21307b226b5280d5e8cfea687bfd2866
> > commit: e5ac9008b79c59235c34494e555419665022f5e1 [4/8] drm/vmwgfx: Use VMware hypercall API
> > config: i386-buildonly-randconfig-002-20240615 (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@xxxxxxxxx/config)
> > compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@xxxxxxxxx/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@xxxxxxxxx/
> >
> > All errors (new ones prefixed by >>):
> >
> >     ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_open_channel.constprop.0':
> > > > vmwgfx_msg.c:(.text+0x203): undefined reference to `vmware_hypercall_slow'
> >     ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_recv_msg':
> >     vmwgfx_msg.c:(.text+0x46f): undefined reference to `vmware_hypercall_slow'
> > > > ld: vmwgfx_msg.c:(.text+0x49c): undefined reference to `vmware_hypercall_slow'
> >     ld: vmwgfx_msg.c:(.text+0x4c3): undefined reference to `vmware_hypercall_slow'
> >     ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_close_channel':
> >     vmwgfx_msg.c:(.text+0x580): undefined reference to `vmware_hypercall_slow'
> >     ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o:vmwgfx_msg.c:(.text+0x729): more undefined references to `vmware_hypercall_slow' follow
> >     ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read':
> >     regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read'
> >     ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write':
> >     regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync'
> >     ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0':
> >     regmap-spi.c:(.text+0x337): undefined reference to `spi_sync'
> >     ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write':
> >     regmap-spi.c:(.text+0x445): undefined reference to `spi_async'
> >     ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init':
> >     ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver'
> >
> > Kconfig warnings: (for reference only)
> >     WARNING: unmet direct dependencies detected for REGMAP_SPI
> >     Depends on [n]: SPI [=n]
> >     Selected by [y]:
> >     - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y])
> >
> > --
>
> Zapping tip:x86/vmware from the tip/master lineup for the time being, until this
> is fixed.
>
> Thx 0day guys for reporting.