Re: [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver

[Markus Elfring]

> This patch adds basic SoundWire codec driver to support for
> WCD9370/WCD9375 TX and RX devices.
…

Please improve such a change description with an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94


…
> +++ b/sound/soc/codecs/wcd937x.c
> @@ -0,0 +1,1677 @@
…
> +static int wcd937x_mbhc_micb_adjust_voltage(struct snd_soc_component *component,
> +					    int req_volt, int micb_num)
> +{
…
> +	mutex_lock(&wcd937x->micb_lock);
> +	/*
> +	 * If requested micbias voltage is same as current micbias
…
> +exit:
> +	mutex_unlock(&wcd937x->micb_lock);
> +	return ret;
> +}
…

Would you become interested to apply a statement like “guard(mutex)(&wcd937x->micb_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196

Regards,
Markus