Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool
From: Jason Wang
Date: Sun Jun 16 2024 - 21:49:34 EST
On Wed, Jun 12, 2024 at 2:30 PM Jiri Pirko <jiri@xxxxxxxxxxx> wrote:
>
> Wed, Jun 12, 2024 at 03:58:10AM CEST, kuba@xxxxxxxxxx wrote:
> >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote:
> >> Add new UAPI to support the mac address from vdpa tool
> >> Function vdpa_nl_cmd_dev_config_set_doit() will get the
> >> MAC address from the vdpa tool and then set it to the device.
> >>
> >> The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:**
> >
> >Why don't you use devlink?
>
> Fair question. Why does vdpa-specific uapi even exist? To have
> driver-specific uapi Does not make any sense to me :/
It came with devlink first actually, but switched to a dedicated uAPI.
Parav(cced) may explain more here.
Thanks
>