Re: [PATCH] scsi: sd: Keep the discard mode stable
From: Christoph Hellwig
Date: Mon Jun 17 2024 - 02:19:00 EST
On Sat, Jun 15, 2024 at 12:03:47AM +0800, Li Feng wrote:
> + /*
> + * When the discard mode has been set to UNMAP, it should not be set to
Overly long line here.
> + * WRITE SAME with UNMAP.
> + */
> + if (!sdkp->max_unmap_blocks)
> + sd_config_discard(sdkp, SD_LBP_WS16);
But more importantly this doesn't really scale to all the variations
of reported / guessed at probe time vs overriden. I think you just
need an explicit override flag that skips the discard settings.