Re: [PATCH 4/4] mfd: tqmx86: add I2C IRQ support

[Matthias Schiffer]

On Fri, 2024-06-14 at 10:49 +0100, Lee Jones wrote:
> 
> 
> Note: Careful not to cut away too much context when replying.
> 
> On Fri, 14 Jun 2024, Gregor Herburger wrote:
> 
> > On Thu, Jun 13, 2024 at 04:42:34PM +0100, Lee Jones wrote:
> > > Just one question; what is (7, 9, 12)?
> > > 
> > > And why is it the same as the GPIO one?  Copy/paste error?
> > > 
> > Those are the IRQ numbers of the PLD. Both blocks, GPIO and I2C, can be
> > configured to use IRQ12, IRQ9 or IRQ7.
> 
> Might I suggest we make that super clear in the help?
> 
> (IRQ7, IRQ9 {and,or} IRQ12)

Well, 7, 9 and 12 are the values you would pass as the module parameter (and we don't want to change
this, as it would be a breaking change). Maybe the following?

"GPIO IRQ number (possible values: 7, 9, 12)"


> 
> Or similar.
> 

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/