Re: [PATCH RESEND] drivers/soc/litex: drop obsolete dependency on COMPILE_TEST

[Jean Delvare]

On Mon, 17 Jun 2024 10:45:09 +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> As a minor optimization, this also lets us drop of_match_ptr() and
> ifdef-guarding, as we now know what they will resolve to, we might as
> well save cpp some work.
> 
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Karol Gugala <kgugala@xxxxxxxxxxxx>
> Cc: Mateusz Holenko <mholenko@xxxxxxxxxxxx>
> Cc: Gabriel Somlo <gsomlo@xxxxxxxxx>
> Cc: Joel Stanley <joel@xxxxxxxxx>

Sorry, I forgot to update this list with:

Reviewed-by: Gabriel Somlo <gsomlo@xxxxxxxxx>

(from https://lkml.org/lkml/2023/12/20/1160 )

-- 
Jean Delvare
SUSE L3 Support