Re: [PATCH v2 5/5] arm64: dts: rockchip: Add cpufreq support to Khadas Edge2

[Alexey Charkov]

On 17/06/2024 11:33, Heiko Stübner wrote:
> Hi Jacobe Zang,
>
> Am Montag, 17. Juni 2024, 09:11:12 CEST schrieb Jacobe Zang:
> > This adjust CPU nodes on Khadas Edge2.
> >
> > Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx>
> > ---
> >   .../arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 12 ++++++++++--
> >   1 file changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> > index 7d7cc3e76838c..5fb15d3dc23e9 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> > @@ -160,34 +160,42 @@ vdd_3v3_sd: vdd-3v3-sd-regulator {
> >   
> >   &cpu_b0 {
> >   	cpu-supply = <&vdd_cpu_big0_s0>;
> > +	mem-supply = <&vdd_cpu_big0_mem_s0>;
> as far as I remember there has not been any binding merged that declares
> this supply. Thankfully following the double phandle below, the Edge2 is
> designed to use the same regulator for the mem-supply, so special handling
> isn't even needed.

Indeed, currently there isn't any user in the mainline tree (neither 
bindings nor drivers) for this separate regulator. Mainline cpufreq-dt 
only expects a single regulator, and as Heiko pointed out Edge2 uses the 
same physical regulator to power both the CPU core and its SRAM, so 
adding a separate mem-supply here isn't helpful.

Best regards, Alexey