Re: [PATCH -next v5 7/8] xfs: speed up truncating down a big realtime inode
From: Zhang Yi
Date: Mon Jun 17 2024 - 05:12:33 EST
On 2024/6/17 14:59, Christoph Hellwig wrote:
> On Sat, Jun 15, 2024 at 07:44:21PM +0800, Zhang Yi wrote:
>> The reason why atomic feature can't split and convert the tail extent on truncate
>> down now is the dio write iter loop will split an atomic dio which covers the
>> whole allocation unit(extsize) since there are two extents in on allocation unit.
>
> We could fix this by merging the two in iomap_begin, as the end_io
> handler already deals with multiple ranges.
Yeah, that's one solution.
> But let's think of that when the need actually arises.
>
Sure, I will retest and submit only patch 6&8 to solve current issue in my next
version.
Thanks,
Yi.