Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics
From: Thomas Gleixner
Date: Mon Jun 17 2024 - 08:58:15 EST
On Sat, Jun 15 2024 at 18:24, Marc Zyngier wrote:
> On Fri, 14 Jun 2024 11:23:53 +0100,
> Shivamurthy Shastri <shivamurthy.shastri@xxxxxxxxxxxxx> wrote:
>> static struct msi_domain_info mbi_pmsi_domain_info = {
>> - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
>> - MSI_FLAG_LEVEL_CAPABLE),
>> + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
>> .ops = &mbi_pmsi_ops,
>> .chip = &mbi_pmsi_irq_chip,
>> };
>
> This patch doesn't do what it says. It simply kills any form of level
> MSI support for *endpoints*, and has nothing to do with any sort of
> "wire to MSI".
>
> What replaces it?
Patch 9/24 switches the wire to MSI with level support over. This just
removes the leftovers.