Re: [PATCH v2 2/2] docs: stable-kernel-rules: remind reader about DCO

[Paul Barker]

On 15/06/2024 03:03, Shung-Hsi Yu wrote:
> When sending patch authored by someone else to stable, it is quite easy for the
> sender to forget adding the Developer's Certification of Origin (DCO, i.e.
> Signed-off-by). An example of such can be seen in the link below. Mention DCO
> explicitly so senders are less likely to forget to do so and cause another
> round-trip.
> 
> Add a label in submitting-patches.rst so we can directly link to the DCO
> section.
> 
> Link: https://lore.kernel.org/stable/2024051500-underage-unfixed-5d28@gregkh/
> Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@xxxxxxxx>
> ---
> Change from v1:
> - explicitly refer to the link as an example in the 1st paragraph (Paul)
> - commit message typo fix s/explicilty/explicitly/ (Paul)
> ---
>  Documentation/process/stable-kernel-rules.rst | 4 ++++
>  Documentation/process/submitting-patches.rst  | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst
> index d22aa2280f6e..85a91fd40da9 100644
> --- a/Documentation/process/stable-kernel-rules.rst
> +++ b/Documentation/process/stable-kernel-rules.rst
> @@ -168,6 +168,10 @@ If the submitted patch deviates from the original upstream patch (for example
>  because it had to be adjusted for the older API), this must be very clearly
>  documented and justified in the patch description.
>  
> +Be sure to also include a :ref:`Developer's Certificate of Origin
> +<sign_your_work>` (i.e. ``Signed-off-by``) when sending patches that you did
> +not author yourself.
> +
>  
>  Following the submission
>  ------------------------
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 66029999b587..98f1c8d8b429 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -394,6 +394,7 @@ e-mail discussions.
>  
>  ``git send-email`` will do this for you automatically.
>  
> +.. _sign_your_work:
>  
>  Sign your work - the Developer's Certificate of Origin
>  ------------------------------------------------------

Reviewed-by: Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>

-- 
Paul Barker

Attachment: OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature