Re: [PATCH v3 0/4] mmc: sdhci-of-dwcmshc: enhance framework

[Chen Wang]

On 2024/6/17 22:18, Jisheng Zhang wrote:
> On Thu, Jun 13, 2024 at 09:42:03AM +0800, Chen Wang wrote:
> > From: Chen Wang <unicorn_wang@xxxxxxxxxxx>
> >
> > When I tried to add a new soc to sdhci-of-dwcmshc, I found that the
> > existing driver code could be optimized to facilitate expansion for
> > the new soc. You can see another patch [sg2042-dwcmshc], which I am
> > working on to add SG2042 to sdhci-of-dwcmshc.
> Hi Chen,
>
> IMHO, you'd better put the sg2042 support as the last patch of this
> series, we want to see why the enhancement is necessary and how does
> it help sg2042 upstreaming.
>
> thanks

OK, I will consider this in next revision.

Thanks,

Chen

> > By the way, although I believe this patch only optimizes the framework
> > of the code and does not change the specific logic, simple verification
> > is certainly better. Since I don't have rk35xx/th1520 related hardware,
> > it would be greatly appreciated if someone could help verify it.
> >
> > ---
> >
> > Changes in v3:
> >    
> >    The patch series is based on latest 'next' branch of [mmc-git].
> >
> >    Improved the dirvier code as per comments from Adrian Hunter.
> >    Define new structure for dwcmshc platform data/ops. In addition, I organized
> >    the code and classified the helper functions.
> >
> >    Since the file changes were relatively large (though the functional logic did
> >    not change much), I split the original patch into four for the convenience of
> >    review.
> >
> > Changes in v2:
> >
> >    Rebased on latest 'next' branch of [mmc-git]. You can simply review or test the
> >    patches at the link [2].
> >
> > Changes in v1:
> >
> >    The patch series is based on v6.9-rc1. You can simply review or test the
> >    patches at the link [1].
> >
> > Link: https://lore.kernel.org/linux-mmc/cover.1713258948.git.unicorn_wang@xxxxxxxxxxx/ [sg2042-dwcmshc]
> > Link: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git [mmc-git]
> > Link: https://lore.kernel.org/linux-mmc/cover.1713257181.git.unicorn_wang@xxxxxxxxxxx/ [1]
> > Link: https://lore.kernel.org/linux-mmc/cover.1714270290.git.unicorn_wang@xxxxxxxxxxx/ [2]
> >
> > ---
> >
> > Chen Wang (4):
> >    mmc: sdhci-of-dwcmshc: adjust positions of helper routines
> >    mmc: sdhci-of-dwcmshc: unify the naming of soc helper functions
> >    mmc: sdhci-of-dwcmshc: extract init function for rk35xx/th1520
> >    mmc: sdhci-of-dwcmshc: add callback functions for dwcmshc
> >
> >   drivers/mmc/host/sdhci-of-dwcmshc.c | 598 ++++++++++++++++------------
> >   1 file changed, 339 insertions(+), 259 deletions(-)
> >
> >
> > base-commit: d6cd1206ffaaa890e81f5d1134856d9edd406ec6
> > --
> > 2.25.1