Re: [PATCH v3 1/4] mmc: sdhci-of-dwcmshc: adjust positions of helper routines

From: Chen Wang
Date: Mon Jun 17 2024 - 20:14:10 EST



On 2024/6/14 18:16, Adrian Hunter wrote:
On 13/06/24 04:42, Chen Wang wrote:
From: Chen Wang <unicorn_wang@xxxxxxxxxxx>

This patch does not change the logic of the code, but only adjusts
the positions of some helper functions in the file according to
categories to facilitate future function search and maintenance.

Category: helper functions (except for driver callback functions
such as probe/remove/suspend/resume) are divided into two categories:

- dwcmshc level helpers
- soc level helpers

After the adjustment, these functions will be put together according
to category.
Please do not move any functions unless it is needed to avoid forward
declaration.

Unnecessarily churning the code makes backports more difficult and
complicates the code history, so it should be avoided in general.

Accepted.

[......]