Re: [PATCH v1 1/2] dt-bindings: leds: Add LED1202 LED Controller

From: Krzysztof Kozlowski
Date: Tue Jun 18 2024 - 02:46:45 EST


On 17/06/2024 23:16, Vicentiu Galanopulo wrote:
> +patternProperties:
> + "^led@[0-9a-f]+$":
> + type: object
> + $ref: common.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + minimum: 0
> + maximum: 11
> +
> + required:
> + - reg
> +
> +additionalProperties: true

This must be false. You can use other bindings as reference: none of
final device schemas have here true.

> +
> +examples:
> + - |
> + #include <dt-bindings/leds/common.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@58 {
> + compatible = "st,led1202";
> + reg = <0x58>;
> + address-cells = <1>;
> + size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + label = "led1_r";

No, use color and function instead.

> + active = <1>;

What's that?

Best regards,
Krzysztof