Re: [PATCH v8 10/10] nvme: Atomic write support

[John Garry]

On 18/06/2024 07:49, Christoph Hellwig wrote:
> > Only NVMe supports an LBA space boundary, so that part is specific to NVMe.
> >
> > Regardless, the block layer already should ensure that the atomic write
> > length and boundary is respected. nvme_valid_atomic_write() is just an
> > insurance policy against the block layer or some other component not doing
> > its job.
> >
> > For SCSI, the device would error - for example - if the atomic write length
> > was larger than the device supported. NVMe silently just does not execute
> > the write atomically in that scenario, which we must avoid.
> It might be worth to expand the comment to include this information to
> help future readers.


OK, will do. I have been asked this more than once now.

John