Re: [PATCH v2] tty: serial: 8250: Fix port count mismatch with the device

[Crescent CY Hsieh]

On Mon, Jun 17, 2024 at 12:54:34PM +0200, Andy Shevchenko wrote:
> On Mon, Jun 17, 2024 at 8:31 AM Crescent Hsieh
> <crescentcy.hsieh@xxxxxxxx> wrote:
> >
> > Normally, the number of ports is indicated by the third digit of the
> > device ID on Moxa PCI serial boards. For example, `0x1121` indicates a
> > device with 2 ports.
> >
> > However, `CP116E_A_A` and `CP116E_A_B` are exceptions; they have 8
> > ports, but the third digit of the device ID is `6`.
> >
> > This patch introduces a function to retrieve the number of ports on Moxa
> > PCI serial boards, addressing the issue described above.
> 
> Now it makes sense to me.
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

Thanks for your review, suggestions and explanation.

---
Sincerely,
Crescent Hsieh