Re: [PATCH v6 4/6] media: hantro: Add RK3588 VEPU121

[Alex Bee]

Am 17.06.24 um 13:30 schrieb Sebastian Reichel:
> Hi,
>
> On Mon, Jun 17, 2024 at 10:50:22AM GMT, Jianfeng Liu wrote:
> > Hi Sebastian,
> >
> > Thu, 13 Jun 2024 15:48:45 +0200, Sebastian Reichel wrote:
> > > +	{ .compatible = "rockchip,rk3588-vepu121", .data = &rk3568_vpu_variant, },
> >
> > rk3568_vpu_variant is decoder's data, typo?
>
> See first sentence of the commit message.
I think, what Jianfeng meant, is that you are incorrectly using
rk3568_vpu_variant for the newly added "rockchip,rk3588-vepu121"
compatible: rk3568_vpu_variant is for the decoder (confusing, I know:
should actually be rk3568_vdpu_variant) - you want to use
rk3568_vepu_variant instead for it instead.

Alex
> -- Sebastian.
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip