RE: [EXTERNAL] Re: [net-next PATCH v5 02/10] octeontx2-pf: RVU representor driver

From: Geethasowjanya Akula
Date: Tue Jun 18 2024 - 06:50:38 EST




>From: Jakub Kicinski <kuba@xxxxxxxxxx>
>Sent: Friday, June 14, 2024 7:32 AM
>To: Geethasowjanya Akula <gakula@xxxxxxxxxxx>
>Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; pabeni@xxxxxxxxxx; edumazet@xxxxxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Subbaraya Sundeep >Bhatta <sbhatta@xxxxxxxxxxx>; Hariprasad Kelam <hkelam@xxxxxxxxxxx>
>Subject: [EXTERNAL] Re: [net-next PATCH v5 02/10] octeontx2-pf: RVU representor driver
>On Tue, 11 Jun 2024 21:52:05 +0530 Geetha sowjanya wrote:

>> obj-$(CONFIG_OCTEONTX2_PF) += rvu_nicpf.o otx2_ptp.o
>> obj-$(CONFIG_OCTEONTX2_VF) += rvu_nicvf.o otx2_ptp.o
>> +obj-$(CONFIG_RVU_ESWITCH) += rvu_rep.o
>>
>> rvu_nicpf-y := otx2_pf.o otx2_common.o otx2_txrx.o otx2_ethtool.o \
>> otx2_flows.o otx2_tc.o cn10k.o otx2_dmac_flt.o \
>> otx2_devlink.o qos_sq.o qos.o
>> rvu_nicvf-y := otx2_vf.o otx2_devlink.o
>> +rvu_rep-y := rep.o otx2_devlink.o

>You gotta fix the symbol duplication first, please:
Submitted the patch that fixes this issue to net branch.
https://patchwork.kernel.org/project/netdevbpf/patch/20240618061122.6628-1-gakula@xxxxxxxxxxx/

>drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf rvu_rep