Re: [net v2 PATCH] net: stmmac: No need to calculate speed divider when offload is disabled

From: Simon Horman
Date: Tue Jun 18 2024 - 07:12:11 EST


On Mon, Jun 17, 2024 at 09:39:22AM +0800, Xiaolei Wang wrote:
> commit be27b8965297 ("net: stmmac: replace priv->speed with
> the portTransmitRate from the tc-cbs parameters") introduced
> a problem. When deleting, it prompts "Invalid portTransmitRate
> 0 (idleSlope - sendSlope)" and exits. Add judgment on cbs.enable.
> Only when offload is enabled, speed divider needs to be calculated.
>
> Fixes: be27b8965297 ("net: stmmac: replace priv->speed with the portTransmitRate from the tc-cbs parameters")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@xxxxxxxxxxxxx>
> ---
>
> Change log:
>
> v1:
> https://patchwork.kernel.org/project/netdevbpf/patch/20240614081916.764761-1-xiaolei.wang@xxxxxxxxxxxxx/
> v2:
> When offload is disabled, ptr is initialized to 0

Thanks for the update.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>