Re: [PATCH v2] ACPI /amba: Fix meaningless code for amba_register_dummy_clk()

From: Sudeep Holla
Date: Tue Jun 18 2024 - 07:14:04 EST


On Mon, Jun 17, 2024 at 08:50:44AM +0800, Youwan Wang wrote:
> Defining `amba_dummy_clk` as static is meaningless.
>
> The amba_register_dummy_clk() function is static and
> is called during initialization. I think 'amba_dummy_clk'
> should be NULL each time when initializing
>

LGTM, can't figure why this was done like this. Looked at v4.6 when this
was introduced, still can't get a clue.

Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>

Please check and include all the maintainers correctly and repost this
patch with my ack. I don't understand how you chose the set of people
or list you have included here.

$ ./scripts/get_maintainer.pl -f drivers/acpi/arm64/amba.c

Also please include Catalin and Will who can pick up this patch and
route it through arm64 tree.

--
Regards,
Sudeep