Re: [PATCH 1/2] x86/cpufeatures: Add HWP highest perf change feature flag

From: srinivas pandruvada
Date: Tue Jun 18 2024 - 07:28:38 EST


On Tue, 2024-06-18 at 11:07 +0200, Borislav Petkov wrote:
> On Mon, Jun 17, 2024 at 08:51:20PM -0700, Srinivas Pandruvada wrote:
> > When CPUID[6].EAX[15] is set to 1, this CPU supports notification
> > for
> > HWP (Hardware P-states) highest performance change.
> >
> > Add a feature flag to check if the CPU supports HWP highest
> > performance
> > change.
> >
> >

[...]

> > +#define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* HWP
> > Highest perf change */
>
> Doesn't belong in /proc/cpuinfo:
>
> #define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* "" HWP
> Highest perf change */
>
>                                                         ^^^^^

Thanks for pointing this out. Will update in v2.

-Srinivas

>
>