Re: [PATCH] net: usb: ax88179_178a: improve link status logs
From: Simon Horman
Date: Tue Jun 18 2024 - 07:43:54 EST
On Mon, Jun 17, 2024 at 12:33:59PM +0200, Jose Ignacio Tornos Martinez wrote:
> Avoid spurious link status logs that may ultimately be wrong; for example,
> if the link is set to down with the cable plugged, then the cable is
> unplugged and afer this the link is set to up, the last new log that is
nit: after
> appearing is incorrectly telling that the link is up.
>
> In order to aovid errors, show link status logs after link_reset
nit: avoid
Nits Flagged by checkpatch.pl --codespell
> processing, and in order to avoid spurious as much as possible, only show
> the link loss when some link status change is detected.
>
> cc: stable@xxxxxxxxxxxxxxx
> Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver")
> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@xxxxxxxxxx>
The nits above notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
...