Re: [PATCH 1/2] lockref: speculatively spin waiting for the lock to be released

[Christian Brauner]

On Thu, Jun 13, 2024 at 12:33:59PM GMT, Linus Torvalds wrote:
> On Thu, 13 Jun 2024 at 11:56, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > I didn't *think* anything in the dentry struct should care about
> > debugging, but clearly that sequence number thing did.
> 
> Looking at the 32-bit build, it looks like out current 'struct dentry'
> is 136 bytes in size, not 128.
> 
> Looks like DNAME_INLINE_LEN should be reduced to 36 on 32-bit.
> 
> And moving d_lockref to after d_fsdata works there too.
> 
> Not that anybody really cares, but let's make sure it's actually
> properly done when this is changed. Christian?

So I verified that indeed on i386 with CONFIG_SMP we need 36 to get to
128 bytes and yes, moving d_lockref after d_fsdata works. So I've put
that patch on top. (Sorry, took a bit. I'm back tomorrow.)