Re: [PATCH V4 8/8] arm64: dts: qcom: sm8650: Add video and camera clock controllers
From: Dmitry Baryshkov
Date: Tue Jun 18 2024 - 10:45:33 EST
On Tue, Jun 18, 2024 at 02:17:23PM GMT, neil.armstrong@xxxxxxxxxx wrote:
> On 02/06/2024 13:44, Jagadeesh Kona wrote:
> > Add device nodes for video and camera clock controllers on Qualcomm
> > SM8650 platform.
> >
> > Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
> > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/sm8650.dtsi | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
[...]
>
> And add the missing required-opps for the clock controllers like
> dispcc.
Unless the opps is required because cmd-db has lower level than
required for the functioning of the device, there should be no need to
add the required-opps.
>
> Thanks,
> Neil
>
>
> > +
> > mdss: display-subsystem@ae00000 {
> > compatible = "qcom,sm8650-mdss";
> > reg = <0 0x0ae00000 0 0x1000>;
>
--
With best wishes
Dmitry