Re: Fwd: Regression: Kernel 6.4 rc1 and higher causes Steam Deck to fail to wake from suspend (bisected)

[Bjorn Helgaas]

On Tue, Jun 18, 2024 at 08:42:07AM +0200, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi Bjorn!
> 
> On 08.05.24 17:49, Bjorn Helgaas wrote:
> > On Tue, Oct 31, 2023 at 03:21:20PM +0700, Bagas Sanjaya wrote:
> >>
> >> I notice a regression report on Bugzilla [1]. Quoting from it:
> >> 
> >>> On Kernel 6.4 rc1 and higher if you put the Steam Deck into suspend then press the power button again it will not wake up. 
> >>>
> >>> I don't have a clue as to -why- this commit breaks wake from suspend on steam deck, but it does. Bisected to:
> >>>
> >>> ```
> >>> 1ad11eafc63ac16e667853bee4273879226d2d1b is the first bad commit
> >>> commit 1ad11eafc63ac16e667853bee4273879226d2d1b
> >>> Author: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >>> Date:   Tue Mar 7 14:32:43 2023 -0600
> >>>
> >>>     nvme-pci: drop redundant pci_enable_pcie_error_reporting()
> >>>     
> >>>     pci_enable_pcie_error_reporting() enables the device to send ERR_*
> >>>     Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> >>>     native"), the PCI core does this for all devices during enumeration, so the
> >>>     driver doesn't need to do it itself.
> >>> [...]
> >>>
> >>> Reverting that commit by itself on top of 6.5.9 (stable) allows it to wake from suspend properly.
> >>
> >>> https://bugzilla.kernel.org/show_bug.cgi?id=218090
> >>
> > I don't think regzbot picked this up [...]
> 
> This is still open and it seems nothing happened for a few weeks now
> (sorry, should have sent a reminder earlier, but such old regressions
> have a lower priority here). Did it fall through the cracks or is this
> some good reason why giving up on this one might be the right thing to do?

Thanks for the reminder.  Will work on it today.

Bjorn