Re: [PATCH] context_tracking: Tag context_tracking_enabled_this_cpu() __always_inline

From: Paul E. McKenney
Date: Tue Jun 18 2024 - 14:08:45 EST


On Mon, Jun 17, 2024 at 08:51:14AM -0700, Sean Christopherson wrote:
> Force context_tracking_enabled_this_cpu() to be inlined so that invoking
> it from guest_context_enter_irqoff(), which KVM uses in non-instrumentable
> code, doesn't unexpectedly leave a noinstr section.
>
> vmlinux.o: warning: objtool: vmx_vcpu_enter_exit+0x1c7: call to
> context_tracking_enabled_this_cpu() leaves .noinstr.text section
> vmlinux.o: warning: objtool: svm_vcpu_enter_exit+0x83: call to
> context_tracking_enabled_this_cpu() leaves .noinstr.text section
>
> Note, the CONFIG_CONTEXT_TRACKING_USER=n stub is already __always_inline.
>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Thank you, Sean, I have queued this for further review and testing.

Thanx, Paul

> ---
> include/linux/context_tracking_state.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/context_tracking_state.h b/include/linux/context_tracking_state.h
> index bbff5f7f8803..1a23d8c7d8c3 100644
> --- a/include/linux/context_tracking_state.h
> +++ b/include/linux/context_tracking_state.h
> @@ -113,7 +113,7 @@ static __always_inline bool context_tracking_enabled_cpu(int cpu)
> return context_tracking_enabled() && per_cpu(context_tracking.active, cpu);
> }
>
> -static inline bool context_tracking_enabled_this_cpu(void)
> +static __always_inline bool context_tracking_enabled_this_cpu(void)
> {
> return context_tracking_enabled() && __this_cpu_read(context_tracking.active);
> }
>
> base-commit: e4e9e1067138e5620cf0500c3e5f6ebfb9d322c8
> --
> 2.45.2.627.g7a2c4fd464-goog
>