Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver

From: Markus Elfring
Date: Tue Jun 18 2024 - 16:48:19 EST



> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -0,0 +1,1741 @@

> +static int e5010_release(struct file *file)
> +{

> + mutex_lock(&e5010->mutex);
> + v4l2_ctrl_handler_free(&ctx->ctrl_handler);

> + kfree(ctx);
> + mutex_unlock(&e5010->mutex);
> +
> + return 0;
> +}


Would you become interested to apply a statement like “guard(mutex)(&e5010->mutex);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196

Regards,
Markus