Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once

[Linus Torvalds]

On Tue, 18 Jun 2024 at 14:34, Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote:
>
> Simply replace WARN_ON_ONCE with WARN_RATELIMIT.

NAK.

Sadly, the RATELIMIT cases are useless.

The normal rate limiting is basically "burst of up to ten, every five seconds".

That's going to completely swamp things and hide any other issue.

If we ratelimit it to "at most 1 per hour", maybe something like that
would be acceptable.

But honestly, I do not understand your "first abuser only" complaint.
There should not be *any* abusers. So just fix that first one already.

If you have more than one, you have bigger issues. So what is the real
reason for this broken patch? Why didn't you fix the first one?

            Linus