Re: [PATCH 1/2] ASoC: codecs:lpass-wsa-macro: Fix vi feedback rate
From: kernel test robot
Date: Tue Jun 18 2024 - 21:20:46 EST
Hi Srinivas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0]
url: https://github.com/intel-lab-lkp/linux/commits/Srinivas-Kandagatla/ASoC-codecs-lpass-wsa-macro-Fix-vi-feedback-rate/20240618-221030
base: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
patch link: https://lore.kernel.org/r/20240618-lpass-wsa-vi-v1-1-416a6f162c81%40linaro.org
patch subject: [PATCH 1/2] ASoC: codecs:lpass-wsa-macro: Fix vi feedback rate
config: i386-buildonly-randconfig-002-20240619 (https://download.01.org/0day-ci/archive/20240619/202406190857.mozJxHDO-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240619/202406190857.mozJxHDO-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406190857.mozJxHDO-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> sound/soc/codecs/lpass-wsa-macro.c:999:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
999 | default:
| ^
sound/soc/codecs/lpass-wsa-macro.c:999:2: note: insert 'break;' to avoid fall-through
999 | default:
| ^
| break;
1 warning generated.
vim +999 sound/soc/codecs/lpass-wsa-macro.c
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 976
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 977 static int wsa_macro_hw_params(struct snd_pcm_substream *substream,
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 978 struct snd_pcm_hw_params *params,
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 979 struct snd_soc_dai *dai)
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 980 {
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 981 struct snd_soc_component *component = dai->component;
2881dae5fbb091 Srinivas Kandagatla 2024-06-18 982 struct wsa_macro *wsa = snd_soc_component_get_drvdata(component);
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 983 int ret;
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 984
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 985 switch (substream->stream) {
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 986 case SNDRV_PCM_STREAM_PLAYBACK:
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 987 ret = wsa_macro_set_interpolator_rate(dai, params_rate(params));
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 988 if (ret) {
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 989 dev_err(component->dev,
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 990 "%s: cannot set sample rate: %u\n",
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 991 __func__, params_rate(params));
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 992 return ret;
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 993 }
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 994 break;
2881dae5fbb091 Srinivas Kandagatla 2024-06-18 995 case SNDRV_PCM_STREAM_CAPTURE:
2881dae5fbb091 Srinivas Kandagatla 2024-06-18 996 if (dai->id == WSA_MACRO_AIF_VI)
2881dae5fbb091 Srinivas Kandagatla 2024-06-18 997 wsa->pcm_rate_vi = params_rate(params);
2881dae5fbb091 Srinivas Kandagatla 2024-06-18 998
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 @999 default:
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 1000 break;
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 1001 }
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 1002 return 0;
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 1003 }
809bcbcecebff8 Srinivas Kandagatla 2020-11-05 1004
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki