Re: [PATCH] zorro: Use str_plural() in amiga_zorro_probe()

From: Geert Uytterhoeven
Date: Wed Jun 19 2024 - 03:09:49 EST


Hi Jiapeng,

On Tue, Jun 18, 2024 at 9:32 AM Jiapeng Chong
<jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
> Use existing str_plural() function rather than duplicating its
> implementation.
>
> ./drivers/zorro/zorro.c:155:22-39: opportunity for str_plural(zorro_num_autocon).
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9350
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/zorro/zorro.c
> +++ b/drivers/zorro/zorro.c
> @@ -152,7 +152,7 @@ static int __init amiga_zorro_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, bus);
>
> pr_info("Zorro: Probing AutoConfig expansion devices: %u device%s\n",
> - zorro_num_autocon, zorro_num_autocon == 1 ? "" : "s");
> + zorro_num_autocon, str_plural(zorro_num_autocon));

Missing #include <linux/string_choices.h>

I will fix that up while applying.

Please try to at least compile-test your patches.
Thanks!

>
> /* First identify all devices ... */
> for (i = 0; i < zorro_num_autocon; i++) {

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds