RE: [PATCH V6 for-6.11/block] loop: Fix a race between loop detach and loop open

[Gulam Mohamed]

Hi Christoph,

> -----Original Message-----
> From: Christoph Hellwig <hch@xxxxxx>
> Sent: Wednesday, June 19, 2024 1:46 PM
> To: Gulam Mohamed <gulam.mohamed@xxxxxxxxxx>
> Cc: linux-block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> yukuai1@xxxxxxxxxxxxxxx; hch@xxxxxx; axboe@xxxxxxxxx
> Subject: Re: [PATCH V6 for-6.11/block] loop: Fix a race between loop detach
> and loop open
> 
> Do we need the re-addition of the open method to fix the ltp test case?  I
> kinda hate it, but if that is what it takes:
> 
I don't think its needed but I kept it because your following comment in the suggested change says " switch the state to roundown here to prevent new openers from coming in":

+	 * Mark the device for removing the backing device on last close.
+	 * If we are the only opener, also switch the state to roundown here to
+	 * prevent new openers from coming in.
 	 */
Please suggest.

Regards,
Gulam Mohamed.
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>