Re: [PATCH v4 1/6] spi: Enable controllers to extend the SPI protocol with MOSI idle configuration

[Mark Brown]

On Wed, Jun 19, 2024 at 09:42:23AM -0300, Marcelo Schmitt wrote:
> On 06/19, Mark Brown wrote:
> > On Tue, Jun 18, 2024 at 08:10:44PM -0300, Marcelo Schmitt wrote:

> > > First replies to v3 brought the idea of having a feature detection mechanism.
> > > I didn't really get how to do that. If feature detection is required, can
> > > somebody please provide some pointers on how to implement that?

> > Look at the checks in spi_setup() for bad_bits.  

> Yes, I added MOSI idle configuration bits to bad_bits so spi_setup() fails
> if the feature is requested but not supported:

> 	bad_bits = spi->mode & ~(spi->controller->mode_bits | SPI_CS_WORD |
> 				 SPI_NO_TX | SPI_NO_RX | SPI_MOSI_IDLE_LOW |
> 				 SPI_MOSI_IDLE_HIGH);

> am I still missing anything?

That should be fine.

Attachment: signature.asc
Description: PGP signature