Re: [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477

[Andrew Lunn]

> +	/* KSZ9477 can only perform HSR offloading for up to two ports */
> +	if (hweight8(dev->hsr_ports) >= 2) {
> +		NL_SET_ERR_MSG_MOD(extack,
> +				   "Cannot offload more than two ports - use software HSR");

Bit of a nit pick. 'use' suggests it is a directive, you need to
changing the configuration to make it work. 'using' would indicate
nothing needs changing, it has decided to use software HSR for you.

Other than that:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew