Re: [PATCH] HID: uclogic: avoid linking common code into multiple modules
From: Jiri Kosina
Date: Wed Jun 19 2024 - 10:30:29 EST
On Fri, 14 Jun 2024, José Expósito wrote:
> > > Turns out that, since the last time I checked the KUnit docs,
> > > we have "EXPORT_SYMBOL_IF_KUNIT" available now.
> > >
> > > I think we can use it and your final patch, without the MODULE_*
> > > changes, could look like:
> >
> > Looks good to me, can you send that with
> >
> > Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> I couldn't add the "Reported-by" tag because check-patch throws a
> warning if it is used without a "Closes" tag.
What?
Let's ignore (or even better fix) checkpatch, this is bad behavior.
> Other than that, I sent v2:
> https://lore.kernel.org/linux-input/20240614161935.230529-1-jose.exposito89@xxxxxxxxx/T/
I'll add Arnd's Reported-by: while applying that, credit must be given.
Thanks,
--
Jiri Kosina
SUSE Labs