Re: [PATCH v2 1/2] HID: uclogic: Avoid linking common code into multiple modules
From: Jiri Kosina
Date: Wed Jun 19 2024 - 10:37:14 EST
On Fri, 14 Jun 2024, José Expósito wrote:
> The hid-uclogic-params.o and hid-uclogic-rdesc.o files are linked
> into both the driver module and the unit test, which triggers a
> W=1 warning:
>
> scripts/Makefile.build:236: drivers/hid/Makefile: hid-uclogic-rdesc.o is added to multiple modules: hid-uclogic hid-uclogic-test
> scripts/Makefile.build:236: drivers/hid/Makefile: hid-uclogic-params.o is added to multiple modules: hid-uclogic hid-uclogic-test
>
> Avoids this by moving these two files into a separate module
> that is used by the driver and the unit test.
>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: José Expósito <jose.exposito89@xxxxxxxxx>
I've added Reported-by: for Arnd and applied, thanks!
--
Jiri Kosina
SUSE Labs