Re: [PATCH] USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by

From: Gustavo A. R. Silva
Date: Wed Jun 19 2024 - 11:27:50 EST




On 19/06/24 16:43, Nathan Chancellor wrote:
On Wed, Jun 19, 2024 at 11:40:57AM +0200, Javier Carrasco wrote:
Use the __counted_by compiler attribute for the data[] flexible array member
to improve the results of array bound sanitizers.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
---
The size is assigned before the first reference to the flexible array
(see pkt_add()), which allows for a straightforward annotation without
further modifications.

Agreed, this seems like a reasonable patch in and of itself that should
work:

Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>

It might also make sense to change the pkt allocation to use
struct_size() instead of open coding it?

+1 :)

Thanks
--
Gustavo