Re: [RFC PATCH 8/9] PCI/AER: Export pci_aer_unmask_internal_errors()

From: Terry Bowman
Date: Wed Jun 19 2024 - 11:42:49 EST




On 6/19/24 02:09, Christoph Hellwig wrote:
> On Mon, Jun 17, 2024 at 03:04:10PM -0500, Terry Bowman wrote:
>> AER correctable internal errors (CIE) and AER uncorrectable internal
>> errors (UIE) are disabled through the AER mask register by default.[1]
>>
>> CXL PCIe ports use the CIE/UIE to report RAS errors and as a result
>> need CIE/UIE enabled.[2]
>>
>> Change pci_aer_unmask_internal_errors() function to be exported for
>> the CXL driver and other drivers to use.
>
> I can't actually find a user for this. Maybe that's because you did
> weird partial CCs for your series, or maybe it's because you don't
> want to tell us. Either way it's a no-go.

The use is in the following patchset (9/9) that missed being shared with
PCI list. If there is rework I'll fix so both are sent to PCI list.

https://lore.kernel.org/all/20240617200411.1426554-10-terry.bowman@xxxxxxx/

Regards,
Terry