Re: [PATCH 3/3] dt-bindings: eeprom: at24: Add at24,mac02e4 and at24,mac02e6
From: Conor Dooley
Date: Wed Jun 19 2024 - 13:54:01 EST
On Wed, Jun 19, 2024 at 10:22:31AM +0300, Andrei Simion wrote:
> Update regex check and add pattern to match both EEPROMs.
>
> Signed-off-by: Andrei Simion <andrei.simion@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 3c36cd0510de..46daa662f6e7 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -18,7 +18,7 @@ select:
> properties:
> compatible:
> contains:
> - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$"
> + pattern: "^atmel,(24(c|cs|mac)[0-9]+[a-z0-9]*|spd)$"
Could we relax the pattern instead to make this bloat less? Would it be
problematic to just allow "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$"?
> required:
> - compatible
>
> @@ -37,8 +37,8 @@ properties:
> - allOf:
> - minItems: 1
> items:
> - - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$"
> - - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$"
> + - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+[a-z0-9]*|spd)$"
> + - pattern: "^atmel,(24(c|cs|mac)[0-9]+[a-z0-9]*|spd)$"
> - oneOf:
> - items:
> pattern: c00$
> @@ -54,6 +54,10 @@ properties:
> pattern: mac402$
> - items:
> pattern: mac602$
> + - items:
> + pattern: mac02e4$
> + - items:
> + pattern: mac02e6$
> - items:
> pattern: c04$
> - items:
> --
> 2.34.1
>
Attachment:
signature.asc
Description: PGP signature