Re: [PATCH v5 2/2] dt-bindings: input: Goodix SPI HID Touchscreen

From: Conor Dooley
Date: Wed Jun 19 2024 - 14:09:17 EST


On Wed, Jun 19, 2024 at 10:16:50AM +0800, Charles Wang wrote:
> Hi Conor,
>
> On Tue, Jun 18, 2024 at 06:43:18PM +0100, Conor Dooley wrote:
> > On Tue, Jun 18, 2024 at 04:44:54PM +0800, Charles Wang wrote:

> > > + reset-gpios:
> > > + maxItems: 1
> > > + description: reset gpio the chip is connected to.
> >
> > The description here isn't needed, it's obvious :)
> >
>
> Ack.
>
> > > + goodix,hid-report-addr:
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + description: |
> >
> > This | is not needed, there's no formatting to preserve.
> >
> > Those are nits:
> > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> >
>
> Thank you. If there is a next version, I will fix these.

Sounds good, thank you!

Attachment: signature.asc
Description: PGP signature