RE: [PATCH 06/15] net: hbl_cn: debugfs support

[Sunil Kovvuri Goutham]

>+
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_disable_decap
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_inject_rx_err
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mac_lane_remap

Don't think debugfs is the correct interface for all this configuration.
Debugfs should ideally be used for dumping runtime device state info for debug purposes.

>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mac_loopback

Why not use ethtool ?

>+
>+What:           /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mmu_bypass

How does this work ?

Thanks,
Sunil.