Re: [PATCH 2/2] sched_ext: Add cpuperf support

[Tejun Heo]

Hello,

On Wed, Jun 19, 2024 at 03:07:51PM +0100, Christian Loehle wrote:
> >  static void sugov_get_util(struct sugov_cpu *sg_cpu, unsigned long boost)
> >  {
> > -	unsigned long min, max, util = cpu_util_cfs_boost(sg_cpu->cpu);
> > +	unsigned long min, max;
> > +	unsigned long util = cpu_util_cfs_boost(sg_cpu->cpu) +
> > +		scx_cpuperf_target(sg_cpu->cpu);
> 
> What does cpu_util_cfs_boost() contain if scx is active?

Hmm... when SCX is in partial mode, cpu_util_cfs_boost() reports the util
metric from cfs side as usual, but, yeah, when scx_switched_all(), this
could be stale. I'll update.

> NIT: reverse xmas

Ah, let me just make the initial assignment a separate statement. Reverse
xmas is awkward with broken lines.

Thanks.

-- 
tejun